Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the helm hook to apply the VMSS label instead of annotations. #25

Open
Mossaka opened this issue Sep 17, 2024 · 2 comments
Open

Comments

@Mossaka
Copy link
Member

Mossaka commented Sep 17, 2024

re: #24

After runtime-class-manager supports node labels, the helm hook should apply the vmss label instead of annotations. Labels set at the VMSS level are automatically applied to all new nodes within a NodePool, ensuring that new nodes inherit the necessary labels even after reallocation.@vdice

@macolso
Copy link

macolso commented Oct 24, 2024

Is node label support on the immediate roadmap for runtime-class-manager? Asking because we may want to take @ThorstenHans up on his offer in #24 to document his workaround in the meantime if there's going to be a wait.

@vdice
Copy link
Collaborator

vdice commented Oct 24, 2024

Runtime-class-manager does operate on the level of labels today, so when kwasm-operator is replaced by it, we can indeed update the helm hook. However, the main prerequisite for swapping in rcm is currently distro support parity with kwasm-operator, with completing the node controller functionality a close second (though if in a time crunch, this could be argued as more of a feature that kwasm-operator doesn't support but we'd get with rcm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants