Skip to content

Commit

Permalink
restructure metrics implementation per review feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
  • Loading branch information
rajatjindal committed Feb 29, 2024
1 parent 63b9c49 commit 8dcaa71
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions internal/controller/spinapp_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/envtest"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/metrics"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
)

Expand Down Expand Up @@ -76,8 +77,9 @@ func TestReconcile_Integration_StartupShutdown(t *testing.T) {
envTest := SetupEnvTest(t)

ctrlr := &SpinAppReconciler{
Client: envTest.k8sClient,
Scheme: scheme.Scheme,
Client: envTest.k8sClient,
Scheme: scheme.Scheme,
MetricsRegistry: metrics.Registry,
}

mgr, err := ctrl.NewManager(envTest.cfg, manager.Options{
Expand Down

0 comments on commit 8dcaa71

Please sign in to comment.