Skip to content

Commit

Permalink
prefer kubectl create over kubectl apply when installing
Browse files Browse the repository at this point in the history
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
  • Loading branch information
bacongobbler committed Mar 6, 2024
1 parent eee84a2 commit fbdbd21
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/helm-install-smoketest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: run spin app
run: |
kubectl apply -f config/samples/simple.yaml
kubectl create -f config/samples/simple.yaml
kubectl rollout status deployment simple-spinapp --timeout 90s
kubectl get pods -A
kubectl port-forward svc/simple-spinapp 8083:80 &
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/smoketest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
--agents 2
- name: apply runtime class
run: kubectl apply -f config/samples/spin-runtime-class.yaml
run: kubectl create -f config/samples/spin-runtime-class.yaml

- name: start controller
timeout-minutes: 5
Expand All @@ -44,8 +44,8 @@ jobs:
- name: run spin app
run: |
kubectl apply -f config/samples/spin-shim-executor.yaml
kubectl apply -f config/samples/simple.yaml
kubectl create -f config/samples/spin-shim-executor.yaml
kubectl create -f config/samples/simple.yaml
kubectl rollout status deployment simple-spinapp --timeout 90s
kubectl port-forward svc/simple-spinapp 8083:80 &
Expand Down
6 changes: 3 additions & 3 deletions charts/spin-operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Prior to installing the chart, you'll need to ensure the following:
<!-- TODO: templatize with release version corresponding to chart's appVersion -->

```console
$ kubectl apply -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.crds.yaml
$ kubectl create -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.crds.yaml
```

## Chart dependencies
Expand Down Expand Up @@ -45,15 +45,15 @@ After installing the chart, you'll need to ensure the following:
<!-- TODO: templatize with release version corresponding to chart's appVersion -->

```console
$ kubectl apply -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.shim-executor.yaml
$ kubectl create -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.shim-executor.yaml
```

- A RuntimeClass resource for the `wasmtime-spin-v2` container runtime is installed. This is the runtime that Spin applications use.

<!-- TODO: templatize with release version corresponding to chart's appVersion -->

```console
$ kubectl apply -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.runtime-class.yaml
$ kubectl create -f https://github.com/spinkube/spin-operator/releases/download/v0.1.0-rc.1/spin-operator.runtime-class.yaml
```

## Upgrading the chart
Expand Down
4 changes: 2 additions & 2 deletions charts/spin-operator/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ Kubernetes cluster before it can run the first Spin application.

1. Install the containerd-shim-spin SpinAppExecutor:

$ kubectl apply -f https://github.com/spinkube/spin-operator/releases/download/{{ .Chart.AppVersion }}/spin-operator.executor.yaml
$ kubectl create -f https://github.com/spinkube/spin-operator/releases/download/{{ .Chart.AppVersion }}/spin-operator.executor.yaml

2. Install the wasmtime-spin-v2 RuntimeClass:

$ kubectl apply -f https://github.com/spinkube/spin-operator/releases/download/{{ .Chart.AppVersion }}/spin-operator.runtime-class.yaml
$ kubectl create -f https://github.com/spinkube/spin-operator/releases/download/{{ .Chart.AppVersion }}/spin-operator.runtime-class.yaml

3. Finally, install the containerd wasm shim on at least one node. This shim is
necessary for running Spin application workloads. We use the Kwasm Operator
Expand Down

0 comments on commit fbdbd21

Please sign in to comment.