nit: prefer kubectl create over kubectl apply
#117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
requested review from
calebschoepp,
endocrimes and
michelleN
as code owners
|
This PR now has an image available for testing: |
|
Personally I prefer apply in interactive cases (a lot of resources want some degree of iteration and edit(up)(enter) in the terminal is useful) - but I think create is fine in the examples here. |
michelleN
reviewed
Mar 4, 2024
There was a problem hiding this comment.
I think this makes sense for the smoke tests but I prefer apply for the same reasons @endocrimes mentioned. I use make deploy for dev and testing and iterate quite a bit so apply would be useful.
|
Okay. I'll go revert |
bacongobbler
force-pushed
the
prefer-kubectl-create
branch
from
e5c3dfa
to
fbdbd21
Compare
michelleN
reviewed
Mar 8, 2024
bacongobbler
force-pushed
the
prefer-kubectl-create
branch
from
fbdbd21
to
63ca0a5
Compare
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
bacongobbler
force-pushed
the
prefer-kubectl-create
branch
from
63ca0a5
to
ade0d04
Compare
|
@bacongobbler can we close this PR or do you think we still need these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this forces the client to return a non-zero exit code if the resource already exists. This should be the preferred method for most situations to ensure we don't accidentally change resources in a prod context.
Are there situations where
kubectl applyis preferred? e.g. in the Makefile during development?