Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: prefer kubectl create over kubectl apply #117

Closed
wants to merge 1 commit into from
Closed

nit: prefer kubectl create over kubectl apply #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/helm-install-smoketest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:

- name: run spin app
run: |
kubectl apply -f config/samples/simple.yaml
kubectl create -f config/samples/simple.yaml
kubectl rollout status deployment simple-spinapp --timeout 90s
kubectl get pods -A
kubectl port-forward svc/simple-spinapp 8083:80 &
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/smoketest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
--agents 2

- name: apply runtime class
run: kubectl apply -f config/samples/spin-runtime-class.yaml
run: kubectl create -f config/samples/spin-runtime-class.yaml

- name: start controller
timeout-minutes: 5
Expand All @@ -44,8 +44,8 @@ jobs:

- name: run spin app
run: |
kubectl apply -f config/samples/spin-shim-executor.yaml
kubectl apply -f config/samples/simple.yaml
kubectl create -f config/samples/spin-shim-executor.yaml
kubectl create -f config/samples/simple.yaml
kubectl rollout status deployment simple-spinapp --timeout 90s

kubectl port-forward svc/simple-spinapp 8083:80 &
Expand Down
Loading