add helm prefix to helm chart artifact #133
Conversation
|
This PR now has an image available for testing: |
.github/workflows/publish.yaml
Outdated
| @@ -120,7 +120,7 @@ jobs: | |||
| echo "CHART_VERSION=$(echo -n ${{ github.ref_name }} | sed -rn 's/(v)?(.*)/\2/p')" >> $GITHUB_ENV | |||
| else | |||
| # TODO: swap '0.0.0' with '$(git describe --tags --abbrev=0 | sed -rn 's/(v)?(.*)/\2/p')' when we have our first tag | |||
| echo "CHART_VERSION=0.0.0-${{ env.APP_VERSION }}" >> $GITHUB_ENV | |||
| echo "CHART_VERSION=helm-0.0.0-${{ env.APP_VERSION }}" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Unfortunately, the helm CLI is strict about chart versions being valid semver (eg must start with [0-9]+.[0-9]+.[0-9]+ and can optionally include prerelease/build metadata as we attach here), so this would break some helm install modes. (See also https://github.com/spinkube/spin-operator/blob/main/Makefile#L139-L142)
I was assuming from #124 (comment) that the ask was to rename the published chart name itself to something like helm-spin-operator... but I could be misunderstanding.
There was a problem hiding this comment.
#124 (comment) was asking for the helm releases to be explicit in the image list - because right now it's not clear what is software bits and what is helm bits unless you happen to know the schema
There was a problem hiding this comment.
Would it be possible to instead move chart artifacts to a different repository in ghcr https://ghcr.io/spinkube/spin-operator-chart ?
I want to be able to install for example: ghcr.io/spinkube/spin-operator-chart:0.0.1
|
that's indeed an option |
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
rajatjindal
force-pushed
the
add-helm-prefix
branch
from
c6c9b52
to
ed810e8
Compare
|
I did some tests for the behavior here: for Instead we might be able to do @vdice what do you think? |
|
I'd be in favor of |
fixes #124