spin-ca: Migrate tests from E2E to unit and integration #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
requested review from
calebschoepp,
bacongobbler and
michelleN
as code owners
Our tests for the Spin CA don't validate that the resulting TLS bundle is used by the shim, so migrate the core of the tests to lighterweight integration and unit tests. A future E2E that installs a bundle and validates outbound-tls would also be excellent.
endocrimes
force-pushed
the
dani/simplify-ca-tests
branch
from
02f5c86
to
4d9c7b0
Compare
michelleN
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests for the Spin CA don't validate that the resulting TLS bundle is used by the shim, so migrate the core of the tests to lighterweight integration and unit tests.
A future E2E that installs a bundle and validates outbound-tls would also be excellent.
I've avoided adding net-new tests here (as a refactor), but intend to follow up in a new PR with tests that cover the pre-existing secret cases, alongside drafts of how we may version the CA bundle.