Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #324

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Spelling #324

merged 1 commit into from
Oct 17, 2024
+9 −9

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 13, 2024 •
edited
Loading

Assorted spelling fixes

@jsoref jsoref marked this pull request as ready for review October 14, 2024 00:04
michelleN
michelleN reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches! I just left one comment above.

internal/controller/spinapp_controller.go Outdated Show resolved Hide resolved
calebschoepp
calebschoepp approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@calebschoepp calebschoepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I would say we're not to fussed about the shape of the commits. Feel free to sign them all or squash it to one commit (I might have a slight but totally non-blocking preference for this).

@jsoref
Fix spelling
70b0eac 
* cannot
* function
* not
* preexisting
* propagation
* recommendation
* unnecessary
* version

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref jsoref requested a review from michelleN October 15, 2024 16:20
@endocrimes endocrimes merged commit c1b079c into spinkube:main Oct 17, 2024
9 checks passed
@jsoref jsoref deleted the spelling branch October 18, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@calebschoepp calebschoepp calebschoepp approved these changes

@bacongobbler bacongobbler Awaiting requested review from bacongobbler bacongobbler is a code owner

@rajatjindal rajatjindal Awaiting requested review from rajatjindal rajatjindal is a code owner

@michelleN michelleN Awaiting requested review from michelleN michelleN is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoref @endocrimes @michelleN @calebschoepp