feat(ecs): update application caching agent to store relationships #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paragbhingre
reviewed
Feb 9, 2021
...src/test/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCacheTest.java
Outdated
Show resolved
Hide resolved
...cs/src/test/java/com/netflix/spinnaker/clouddriver/ecs/cache/ApplicationCacheClientTest.java
Show resolved
Hide resolved
allisaurus
reviewed
Feb 9, 2021
.../main/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCachingAgent.java
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
...src/main/java/com/netflix/spinnaker/clouddriver/ecs/cache/client/ApplicationCacheClient.java
Outdated
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
...cs/src/test/java/com/netflix/spinnaker/clouddriver/ecs/cache/ApplicationCacheClientTest.java
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
...src/test/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCacheTest.java
Outdated
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
.../main/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCachingAgent.java
Outdated
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
.../main/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCachingAgent.java
Outdated
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
.../main/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCachingAgent.java
Outdated
Show resolved
Hide resolved
allisaurus
reviewed
Feb 18, 2021
...t/java/com/netflix/spinnaker/clouddriver/ecs/provider/agent/ApplicationCachingAgentTest.java
Outdated
Show resolved
Hide resolved
piradeepk
force-pushed
the
search
branch
3 times, most recently
from
92fcd2e
to
db79103
Compare
allisaurus
reviewed
Feb 23, 2021
...src/main/java/com/netflix/spinnaker/clouddriver/ecs/cache/client/ApplicationCacheClient.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/netflix/spinnaker/clouddriver/ecs/cache/client/ApplicationCacheClient.java
Show resolved
Hide resolved
...cs/src/test/java/com/netflix/spinnaker/clouddriver/ecs/cache/ApplicationCacheClientTest.java
Outdated
Show resolved
Hide resolved
allisaurus
approved these changes
Feb 24, 2021
piradeepk
added
ready to merge
EasyAsABC123
pushed a commit
to EasyAsABC123/clouddriver
that referenced
this pull request
Mar 9, 2021
opsmxdemo
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
Mar 10, 2021
opsmxdemo
pushed a commit
to OpsMx/clouddriver
that referenced
this pull request
Mar 10, 2021
allisaurus
added a commit
to allisaurus/clouddriver
that referenced
this pull request
Apr 19, 2021
…ion and relationships (spinnaker#5234)" This reverts commit f457954.
piradeepk
added a commit
to piradeepk/clouddriver
that referenced
this pull request
Apr 21, 2021
piradeepk
added a commit
to piradeepk/clouddriver
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the application caching agent to store the application name as well as the services associated to that application as relationships. Storing these objects allows the EcsApplicationProvider to be able to query and retrieve all applications and their related services. Improving the search experience and returning the records quicker.
Previously, if users had too many services in their associated aws accounts, the search would time out, and throw an exception.
Tested by using the current logic, to perform multiple application searches (both using the application search and well as the shared search modal), as well as clicking through an application and deploying to ECS. Then deployed these changes and redid the same tests to validate that the previous behaviour continued to work and the search was able to function as expected.
Fixes: spinnaker/spinnaker#6084