fix(cloudfoundry): Update ProcessStats model due to capi-1.84.0 changes #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmcintosh
approved these changes
Sep 23, 2024
...pinnaker/clouddriver/cloudfoundry/deploy/ops/StopCloudFoundryServerGroupAtomicOperation.java
Show resolved
Hide resolved
christosarvanitis
added a commit
to armory-io/clouddriver
that referenced
this pull request
Sep 25, 2024
|
@mergify backport release-1.34.x release-1.33.x release-1.35.x release-1.32.x |
✅ Backports have been created
|
This was referenced Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudfoundry API 1.84.0 is shipped with a fix for cloudfoundry/cloud_controller_ng#3834. Summary of the change is:
Before the change when an app was stopped the state was immediately returned as DOWN although a graceful shutdown period may existed before actually was stopped.
After the change when an app is stopped if within a graceful shutdown period the state will be returned as STOPPING -> DOWN
Clouddriver ProcessStats model is updated with this PR to include the STOPPING state. Additionally updated the StopCloudFoundryServerGroupAtomicOperation to wait until the Graceful shutdown period expires.