Skip to content

Commit

Permalink
Merge branch 'master' into dependabot/npm_and_yarn/packages/app/webpa…
Browse files Browse the repository at this point in the history
…ck-5.94.0
  • Loading branch information
jasonmcintosh authored Sep 13, 2024
2 parents 56251b1 + 08b95df commit c850e30
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,3 @@ For now, you can look at the [all modules](https://github.com/spinnaker/deck/tre
get an idea how we are customizing Deck internally. Expect a lot of this to change, though, as we figure out better, cleaner
hooks and integration points. And we're happy to provide new integration points (or accept pull requests) following
those existing conventions if you need an integration point that doesn't already exist.

## Join Us

Interested in sharing feedback on Spinnaker's UI or contributing to Deck?
Please join us at the [Spinnaker UI SIG](https://github.com/spinnaker/governance/tree/master/sig-ui-ux)!
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,9 @@ angular
spotMaxPrice = launchTemplateData.instanceMarketOptions?.spotOptions?.maxPrice;
command.instanceType = launchTemplateData.instanceType;
command.viewState.useSimpleInstanceTypeSelector = true;
if (launchTemplateData.userData) {
command.base64UserData = launchTemplateData.userData;
}
}

if (serverGroup.mixedInstancesPolicy) {
Expand Down Expand Up @@ -434,7 +437,8 @@ angular
command.viewState.useSimpleInstanceTypeSelector = isSimpleModeEnabled(command);
}

const ipv6AddressCount = _.get(launchTemplateData, 'networkInterfaces[0]');
const networkInterfaces = _.get(launchTemplateData, 'networkInterfaces[0]');
const ipv6AddressCount = (networkInterfaces as INetworkInterface)?.ipv6AddressCount ?? 0;

const asgSettings = AWSProviderSettings.serverGroups;
const isTestEnv = serverGroup.accountDetails && serverGroup.accountDetails.environment === 'test';
Expand Down
1 change: 1 addition & 0 deletions packages/app/src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ window.spinnakerSettings = {
defaultManifest: 'spinnaker.yml',
manifestBasePath: '.spinnaker',
},
maxFetchHistoryOnEvaluateVariables: 100,
maxPipelineAgeDays: 14,
newApplicationDefaults: {
chaosMonkey: false,
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/config/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export interface ISpinnakerSettings {
manifestBasePath: string;
urls?: Partial<IManagedDeliveryURLs>;
};
maxFetchHistoryOnEvaluateVariables?: number;
maxPipelineAgeDays: number;
newApplicationDefaults: INewApplicationDefaults;
notifications: INotificationSettings;
Expand Down Expand Up @@ -175,6 +176,7 @@ SETTINGS.managedDelivery = SETTINGS.managedDelivery || {
defaultManifest: 'spinnaker.yml',
manifestBasePath: '.spinnaker',
};
SETTINGS.maxFetchHistoryOnEvaluateVariables = SETTINGS.maxFetchHistoryOnEvaluateVariables ?? 100;

// A helper to make resetting settings to steady state after running tests easier
const originalSettings: ISpinnakerSettings = cloneDeep(SETTINGS);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { isEqual, keyBy } from 'lodash';
import React from 'react';
import type { Option } from 'react-select';

import { SETTINGS } from '../../../../config';
import type { IExecution, IPipeline, IStage } from '../../../../domain';
import type { IStageForSpelPreview } from '../../../../presentation';
import { FormField, ReactSelectInput, useData } from '../../../../presentation';
Expand All @@ -23,7 +24,10 @@ export function ExecutionAndStagePicker(props: IExecutionAndStagePickerProps) {
const [showStageSelector, setShowStageSelector] = React.useState(false);

const fetchExecutions = useData(
() => executionService.getExecutionsForConfigIds([pipeline.id], { limit: 100 }),
() =>
executionService.getExecutionsForConfigIds([pipeline.id], {
limit: SETTINGS.maxFetchHistoryOnEvaluateVariables,
}),
[],
[],
);
Expand Down

0 comments on commit c850e30

Please sign in to comment.