Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Wait Stage restartable #10073

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

Sitkevich88
Copy link
Contributor

I think, It is necessary to make Wait stage restartable, because if you cancel release pipeline, while Wait Stage is running, you won't be able to restart pipeline where it stopped, you will be forced to restart pipeline from the very beginning.

Before:
image

After:
image

Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with making it restartable. Kinda surprised there isn't a setting default on this in orca but didn't see much. I'm not AS familiar with some of the backend logic on this but overall I'd THINK this would make sense to me :)

@Sitkevich88
Copy link
Contributor Author

@jasonmcintosh , Wait stage is restartable on backend by default, the problem was only the lack of a button on the UI.

@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label Feb 1, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 1, 2024
@jasonmcintosh
Copy link
Member

Looks good thanks!

@mergify mergify bot merged commit f3df056 into spinnaker:master Feb 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.34
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants