fix(runJobs): Persist External Log links after the deletion of the pods #10081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiupopa07
approved these changes
Apr 15, 2024
|
Backport candidate for all active releases (1.33.x, 1.32.x) if you agree |
ovidiupopa07
approved these changes
Apr 15, 2024
mattgogerly
approved these changes
Apr 15, 2024
|
@Mergifyio backport release-1.33.x release-1.32.x |
✅ Backports have been created
|
This was referenced Apr 16, 2024
Merged
mergify bot
added a commit
that referenced
this pull request
Apr 16, 2024
…ds (#10081) (#10083) * fix(runJobs): Persist External Log links after the deletion of the pods * fix(runJobs): Persist External Log links after the deletion of the pods --------- Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> (cherry picked from commit fd55cf1) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot
added a commit
that referenced
this pull request
Apr 16, 2024
…ds (#10081) (#10084) * fix(runJobs): Persist External Log links after the deletion of the pods * fix(runJobs): Persist External Log links after the deletion of the pods --------- Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> (cherry picked from commit fd55cf1) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jun 5, 2024
…ds (spinnaker#10081) (spinnaker#10083) * fix(runJobs): Persist External Log links after the deletion of the pods * fix(runJobs): Persist External Log links after the deletion of the pods --------- Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> (cherry picked from commit fd55cf1) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jun 5, 2024
…ds (spinnaker#10081) (spinnaker#10083) * fix(runJobs): Persist External Log links after the deletion of the pods * fix(runJobs): Persist External Log links after the deletion of the pods --------- Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> (cherry picked from commit fd55cf1) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
sahititarigoppula
pushed a commit
to OpsMx/deck-oes
that referenced
this pull request
Jun 5, 2024
…ds (spinnaker#10081) (spinnaker#10083) * fix(runJobs): Persist External Log links after the deletion of the pods * fix(runJobs): Persist External Log links after the deletion of the pods --------- Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com> (cherry picked from commit fd55cf1) Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the deletion of the runjob (for any reason) Deck instead of persisting the External system link for the logs it falls back to the default Console Output.
Since the user is linking the logs of a Runjob to an external system it makes sense that the link for the previous executions should persist in Deck.
Fixes this old issue: spinnaker/spinnaker#5717