refactor(kubernetes): convert find artifacts from resource stage to react #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgogerly
approved these changes
Dec 10, 2024
cristhian-castaneda
deleted the
refactor/reactify-find-artifacts-from-resource-stage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the refactoring of the Find Artifacts From Resource (Manifest) stage, part of the ongoing effort to transition Kubernetes stages to React. For additional context, please refer to spinnaker/spinnaker#4254
Changes Made
findArtifactsFromResourceConfig.htmlandfindArtifactsFromResourceConfig.controller.tshave been converted into the new componentsFindArtifactsFromResourceConfig.tsxandFindArtifactsFromResourceStageForm.tsx.Stage Views
Stage Config
Execution Details Sections
Execution Details Tasks
Execution Artifact