fix(stages): accountExtractor in k8s stages should extract data from a context #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgogerly
approved these changes
Dec 10, 2024
|
@kbatalin mind resolving the conflict so this can hop aboard the merge train? |
…a context For reference, see other stages: - https://github.com/spinnaker/deck/blob/c96faa581482d251c07132bdcc023e04fc8e869b/packages/cloudfoundry/src/pipeline/stages/runJob/cloudFoundryRunJob.module.ts#L8 - https://github.com/spinnaker/deck/blob/c49d9b545642f511bfd2e14588b78fdf76385c5a/packages/amazon/src/pipeline/stages/cloneServerGroup/awsCloneServerGroupStage.js#L18 During execution, the account is stored in the context
kbatalin
force-pushed
the
fix-account-selector
branch
from
bdeaade to
89cceed
Compare
|
@mattgogerly |
mattgogerly
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, see other stages:
deck/packages/cloudfoundry/src/pipeline/stages/runJob/cloudFoundryRunJob.module.ts
Line 8 in c96faa5
deck/packages/amazon/src/pipeline/stages/cloneServerGroup/awsCloneServerGroupStage.js
Line 18 in c49d9b5
During execution, the account is stored in the context
Screenshot after fixing: