-
Notifications
You must be signed in to change notification settings - Fork 652
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(triggers): prevent double-triggering for pipelines with >1 trigge…
…rs (#529) * fix(triggers): prevent double-triggering for pipelines with >1 triggers A pipeline with 2 triggers and an event matching one of them could actually be triggered twice. The problem is that withMatchingTrigger would consider the event and all triggers of the pipeline, and it would be called once for each trigger. The key fix is to matchTriggerFor(event) in getMatchingPipelines(). As a result, we can change the inputs of getMatchingPipelines to an event and a matching trigger instead of an event and a pipeline (with all its triggers).
- Loading branch information
Showing
4 changed files
with
55 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters