Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exceptions): Add SpinnakerRetrofitErrorHandler and replace RetrofitError catch blocks #972

Merged

Conversation

alice485
Copy link
Contributor

This pull request registers SpinnakerRetrofitErrorHandler with each Retrofit.RestAdapter and replaces each RetrofitError catch block with a catch-block using SpinnakerServerException or the appropriate subclass.

This change does not alter any of this service's behavior, it merely allows error messages to be surfaced even when the error was thrown in a microservice more than one network call from the service in which the request originated.

This is part of an effort to consume SpinnakerRetrofitErrorHandler in each Spinnaker microservice, as detailed in spinnaker/spinnaker#5473

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • c75541c: add spinnakerRetrofitErrorHandler and replace RetrofitError catch blocks with SpinnakerServerException, etc

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

abe garcia added 2 commits June 23, 2023 16:17
…fitError catch blocks with SpinnakerServerException, etc
…fitError catch blocks with SpinnakerServerException, etc
@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Aug 8, 2023
@mergify mergify bot added the auto merged label Aug 8, 2023
@mergify mergify bot merged commit d244c9d into spinnaker:master Aug 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants