-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exceptions): Add SpinnakerRetrofitErrorHandler and replace RetrofitError catch blocks #972
Merged
mergify
merged 10 commits into
spinnaker:master
from
alice485:feat-add-spinnakerretrofiterrorhandler
Aug 8, 2023
Merged
feat(exceptions): Add SpinnakerRetrofitErrorHandler and replace RetrofitError catch blocks #972
mergify
merged 10 commits into
spinnaker:master
from
alice485:feat-add-spinnakerretrofiterrorhandler
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks with SpinnakerServerException, etc
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
…fitError catch blocks with SpinnakerServerException, etc
…fitError catch blocks with SpinnakerServerException, etc
dbyron-sf
reviewed
Jun 23, 2023
dbyron-sf
reviewed
Jun 23, 2023
kayenta-core/src/main/java/com/netflix/kayenta/metrics/SynchronousQueryProcessor.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 23, 2023
...e-configbin/src/main/java/com/netflix/kayenta/configbin/storage/ConfigBinStorageService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 23, 2023
...e-configbin/src/main/java/com/netflix/kayenta/configbin/storage/ConfigBinStorageService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jun 23, 2023
kayenta-signalfx/src/main/java/com/netflix/kayenta/signalfx/metrics/SignalFxMetricsService.java
Outdated
Show resolved
Hide resolved
…in ConfigBinStorageService.java
dbyron-sf
reviewed
Aug 8, 2023
kayenta-core/src/main/java/com/netflix/kayenta/metrics/SynchronousQueryProcessor.java
Outdated
Show resolved
Hide resolved
…ion and SpinnakerHttpException
dbyron-sf
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request registers SpinnakerRetrofitErrorHandler with each Retrofit.RestAdapter and replaces each RetrofitError catch block with a catch-block using SpinnakerServerException or the appropriate subclass.
This change does not alter any of this service's behavior, it merely allows error messages to be surfaced even when the error was thrown in a microservice more than one network call from the service in which the request originated.
This is part of an effort to consume SpinnakerRetrofitErrorHandler in each Spinnaker microservice, as detailed in spinnaker/spinnaker#5473