feat(retrofit): add accessor to exception response body as a map #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SheetalAtre
force-pushed
the
retrofitException_getBodyAs_map
branch
from
a2856c1
to
20d2bef
Compare
dbyron-sf
changed the title
dbyron-sf
changed the title
dbyron-sf
reviewed
Jul 9, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 9, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 10, 2023
...c/test/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerServerExceptionTest.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 10, 2023
...c/test/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerServerExceptionTest.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Jul 10, 2023
| RetrofitErrorResponseBody body = | ||
| (RetrofitErrorResponseBody) e.getBodyAs(RetrofitErrorResponseBody.class); | ||
| responseBody = (Map<String, Object>) e.getBodyAs(HashMap.class); | ||
|
|
||
| this.rawMessage = |
There was a problem hiding this comment.
I have a feeling we'll end up initializing rawMessage something like this
this.rawMessage = e.getMessage();
when we start handling e.g. non-json response bodies. It's possible that would simplify the code here even before that. I'm OK to leave this as it is for now....especially if there's a way to make rawMessage totally disappear.
SheetalAtre
force-pushed
the
retrofitException_getBodyAs_map
branch
from
9b40cd5
to
5ea7274
Compare
dbyron-sf
reviewed
Jul 11, 2023
...fit/src/main/java/com/netflix/spinnaker/kork/retrofit/exceptions/SpinnakerHttpException.java
Outdated
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
retrofitException_getBodyAs_map
branch
from
5ea7274
to
ee3c63d
Compare
dbyron-sf
approved these changes
Jul 12, 2023
SheetalAtre
force-pushed
the
retrofitException_getBodyAs_map
branch
from
ee3c63d
to
14d16fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(retrofit): add accessor to exception response body as a map