Skip to content

Commit

Permalink
pin clang-format version in CI to the same version as in pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
Puerling committed Sep 6, 2024
1 parent c2187ba commit b8e0276
Showing 1 changed file with 21 additions and 15 deletions.
36 changes: 21 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,30 @@ jobs:
- name: 📚 Install required system packages
run: |
sudo apt-get update
sudo apt-get install xorg-dev libglu1-mesa-dev libgtk-3-dev clang-format-18 clang-tidy-18
sudo apt-get install xorg-dev libglu1-mesa-dev libgtk-3-dev tree
- uses: actions/setup-python@v4
with:
python-version: '3.10'

- name: 📚 Install python packages
run: pip install --user numpy pylint black
run: >
pip install --user numpy pylint
"black==22.10.0"
"clang-format==18.1.8"
"clang-tidy==18.1.8"
- name: 🧪 Python code formatting check
shell: bash
run: |
black core/python --check
black ui-python --check
- name: 🧪 Python code quality checks, linting
shell: bash
run: |
tree core/python
pylint core/python/spirit --fail-under=8
- name: 📁 Create build folder
run: cmake -E make_directory ${{runner.workspace}}/build
Expand All @@ -40,8 +56,8 @@ jobs:
if: always()
shell: bash
run: |
clang-format-18 --version
OUTPUT=$($SOURCES | xargs clang-format-18 -n 2>&1)
clang-format --version
OUTPUT=$($SOURCES | xargs clang-format -n 2>&1)
if [[ $OUTPUT ]]; then
echo "$OUTPUT"
exit 1
Expand All @@ -51,17 +67,7 @@ jobs:
if: always()
shell: bash
run: |
clang-tidy-18 --version
- name: 🧪 Python code formatting check
shell: bash
run: |
black core/python --check
black ui-python --check
- name: 🧪 Python code quality checks, linting
shell: bash
run: pylint core/python/spirit --fail-under=8
clang-tidy --version
test-gcc:
name: gcc ${{ matrix.parallelisation }} (${{ matrix.os }})
Expand Down

0 comments on commit b8e0276

Please sign in to comment.