Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jpeg blob capture #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nijk
Copy link
Contributor

@nijk nijk commented Apr 21, 2017

Addresses issue #48

@spite
Copy link
Owner

spite commented Apr 21, 2017

So what does this return when .save() is called?

@nijk
Copy link
Contributor Author

nijk commented Apr 21, 2017

I guess I haven't really catered for the case where .save() is called without a callback - I suppose I haven't considered it because it doesn't really make sense to do that when you want to obtain an array of blobs rather than having the capturer download a collection of files for you.

On reflection, it may be a better pattern to augment the existing CCJPEGEncoder to allow the flexibility of a Tar of Images or Array of Blobs on .save() and also allow for the callback on each frame .add().

@nijk
Copy link
Contributor Author

nijk commented Apr 24, 2017

@spite Any thoughts on this?

@spite
Copy link
Owner

spite commented May 8, 2017

I guess I don't understand why you need to create a new Frame Encoder. Why doesn't the current JPEG/PNG encoder work for your needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants