Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default value for the expense shares field #113

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix the default value for the expense shares field #113

merged 3 commits into from
Feb 28, 2024

Conversation

sashkent3
Copy link
Contributor

Closes #112

shynst
shynst approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@shynst shynst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you!

shynst added a commit to shynst/spliit that referenced this pull request Feb 27, 2024
@shynst
Fix the default value for the expense shares field (spliit-app#113)
2e3e01f
@scastiel
Copy link
Member

💯

@scastiel
Copy link
Member

@sashkent3 could you please run Prettier in your branch (npx prettier -w src) to make the pipeline pass? 😉

@sashkent3
Copy link
Contributor Author

@scastiel Done, my bad!

@scastiel
Copy link
Member

@scastiel Done, my bad!

No worries, thanks 😊

@scastiel scastiel merged commit 6a5efc5 into spliit-app:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shynst shynst shynst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Default share value is 0.01 (sent as 1), should be 1 (sent as 100)
3 participants
@sashkent3 @scastiel @shynst