add activity log to expense form #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok after a few attempts I think I got this back up to date! |
|
@scastiel this is ready to go unless you have other comments. |
|
@scastiel bump 😀 |
|
Closing to re-visit after comments feature is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a list of activity for the current expense in the edit expense form. This makes use of the recent merge of #141, which added a basic activity log.
I have chosen to create new ExpenseActivityList and ExpenseActivityItem components rather than re-use ActivityList and ActivityItem so they can be extended in future to include, for example, a summary of what exactly was changed in the update.
This PR closes #160.
No Activity
Activity List