Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Duplicate expense #201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Maxco10
Copy link
Contributor

@Maxco10 Maxco10 commented Aug 8, 2024

This pull request adds the "Clone expense" feature to Spliit projects.
The feature can be useful as shortcut for all similar transactions.

EDIT1: The cloned expense will have new Date() as date.

PR.mov

@Maxco10 Maxco10 changed the title Cloning feature. Cloning transactions feature. Aug 8, 2024
@Maxco10 Maxco10 changed the title Cloning transactions feature. Cloning expenses feature. Aug 8, 2024
@Maxco10 Maxco10 changed the title Cloning expenses feature. Feature/Cloning expense. Aug 13, 2024
@Maxco10 Maxco10 changed the title Feature/Cloning expense. Feature/Cloning expense Aug 13, 2024
@Maxco10 Maxco10 changed the title Feature/Cloning expense Feature/Duplicate expense Aug 29, 2024
@Maxco10
Copy link
Contributor Author

Maxco10 commented Oct 8, 2024

Updated PR with latest change on languages

@CarliJoy
Copy link

CarliJoy commented Oct 9, 2024

From a user perspective it is not clear what happens with the date? Why should I create a expense with the same date and time?
I would expect that the date is not copied but a new expense with the current date is created.
But than it is not really a clone rather a recreation.
Maybe in the clone dialog it would be nice to change the creation date directly with the option to set it to today?

@Maxco10
Copy link
Contributor Author

Maxco10 commented Oct 10, 2024

@CarliJoy
Thank you for your feedback.
When I made the feature, I was thiking a clone of expense(all fields) but your point of view, it is correct about date.

@Maxco10
Copy link
Contributor Author

Maxco10 commented Oct 14, 2024

The cloned expense will have new Date() as date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants