Fix #209: Correctly display loaded expense #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't load default split options after displaying an existing expense - Re-validate form after changing the "paidFor" selection. This fixes the error message "The expense must be paid for at least one participant." after clicking "Select None" and the selecting one participant.
|
This needs to be fixed quickly. I have already faced issues when editing my expenses, all the participants were getting added by default even though I was only trying to edit something else. Btw, you should look into #194 as well. "Split Unevenly by amount" still has the issue in your PR I believe. Maybe we can rewrite this "auto rebalance" logic so not to create problem when editing expense. I will try to look into it. Update: I have created a PR to your fork to fix the issue. Please check when you are free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error message "The expense must be paid for at least one participant." after clicking "Select None" and the selecting one participant.