Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amount preview for scanned receipts #227

Merged
merged 9 commits into from
Sep 28, 2024

Conversation

mertd
Copy link
Contributor

@mertd mertd commented Sep 25, 2024

To ensure the formatter works as expected, I also set up testing. The test cases ended up taking a lot more time than the fix itself, but I wanted to make sure not to introduce any other unexpected formatting bug.

As a mostly unrelated change, I needed to change the GPT model used as I was getting depreciation errors during development.

Fixes #87 @RayBB
Fixes #140 @Phlipde
Fixes #121 @webzit

Do the changes from #81 still work as expected @justcallmelarry?

@mertd mertd marked this pull request as draft September 25, 2024 10:21
@mertd
Copy link
Contributor Author

mertd commented Sep 25, 2024

@scastiel I remember now why I left this branch untouched for a long time: I couldn't test if this actually fixed the issue without being able to upload to a public S3 instance. However, when I picked this up again yesterday, I assumed I had it tested manually already and just needed to finish up the automatic util tests. 😅

Could you please trigger a preview deployment with Vercel? If not, I will have to pick this up again later for some testing with a public S3 instance.

@scastiel
Copy link
Member

Hey @mertd, I just tested and it works like a charm!

I'm taking the liberty to assume your PR is "ready for review" so I can merge it (I don't have much time to dedicate to Spliit, so who knows when I have a PR-merging moment in the future 😉).

Thanks very much! (And thanks for introducing Jest too, might be useful!)

@scastiel scastiel marked this pull request as ready for review September 28, 2024 22:38
@scastiel scastiel merged commit 9a5674e into spliit-app:main Sep 28, 2024
1 check passed
@mertd mertd deleted the amount-preview branch September 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants