Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spliit's version in the footer #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Maxco10
Copy link
Contributor

@Maxco10 Maxco10 commented Oct 29, 2024

Hi,

This pull request will adding a simple badge for version in the footer of project in order to display what version is using.
The version is get from package.json.

Each new version of the project will need to update the package.json with a version value.

Screenshot 2024-10-29 at 15 33 01

@tasken
Copy link

tasken commented Nov 9, 2024

Why not add this to the existing footer details? The way is placed now seems off the content section.

@Maxco10
Copy link
Contributor Author

Maxco10 commented Nov 11, 2024

@tasken, the label with version is in the footer :) see the code

@tasken
Copy link

tasken commented Nov 11, 2024

Sorry, I'm looking at the screenshot.
I mean to align it with the existing logo and credits as an extra line. It's just a suggestion.

@Maxco10
Copy link
Contributor Author

Maxco10 commented Nov 11, 2024

@tasken do not worry.
Thank you for you feedback. I put this label in the corner because it is a out-of-scope with the data in the footer(logo and credits).
Let's space to community for other feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants