Group expenses #48
Group expenses #48
Conversation
|
@acuteengle is attempting to deploy a commit to the Sebastien Castiel Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @acuteengle it looks great! There are some TypeScript errors in your code, could you please fix them? You can run A non-blocking suggestion (I can deal with it after merge): instead of displaying all the dates, maybe we could use groups such as “This week”, “Earlier this month”, “Last month”, “Last year”, “Older”, what do you think? |
scastiel
force-pushed
the
main
branch
3 times, most recently
from
d067d96
to
6b6d58e
Compare
scastiel
force-pushed
the
group-by-expense-date
branch
from
91aa1c6
to
fa006e9
Compare
Ah thanks! Done! I also ran |
| return Math.round(differenceInTime / (1000 * 3600 * 24)) // convert milliseconds to days | ||
| } | ||
|
|
||
| function getExpenseGroup(date: Dayjs, today: Dayjs) { |
There was a problem hiding this comment.
Originally I had this:
But then I realized that the headers were then misleading so I have to actually check if the expense date is in the same week, or month, or year, etc. Because of that, I had to utilize the dayjs package
|
@scastiel Ready for another look! 
|
Closes #27