Add test to verify database parameter is propagated to Predis #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP SDK
What did you accomplish?
Since the Split Synchronizer documentation recommends using a dedicated Redis database for splits users might need to specify the database they're using when initializing the SDK instance.
While this functionality already exists it is:
a) not documented in Split.io PHP SDK page
b) as far as I can tell, not tested
This PR is aimed at fixing point b), and raising the question on how to fix point a).
How do we test the changes introduced in this PR?
The change is the test: we added a
testDatabaseParameterIsPropagatedToPredisClient
inSdkClientTest
to verify the database parameter is propagated to the Predis client.Extra Notes
How can we address point a), that is, how can we make it obvious in Split.io PHP SDK page that
database
is an accepted parameter?