Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws integration creation should implement backoff retry #308

Closed
xp-1000 opened this issue Jul 2, 2021 · 1 comment
Closed

aws integration creation should implement backoff retry #308

xp-1000 opened this issue Jul 2, 2021 · 1 comment

Comments

@xp-1000
Copy link
Contributor

xp-1000 commented Jul 2, 2021

Hello,

the aws integration resource obviously requires an aws role with right applied policy to be use during its creation (and validation).

automating all of this process leads to permission denied error because if you create the role and its policy with terraform so it will try to create the integration before the policy is really applied.

the right solution to address this issue is to implement a backoff retry and properly handle the permission denied error into the signalfx provider.

this what official aws provider does for lambda (which also depends on role/policy) : https://github.com/hashicorp/terraform-provider-aws/pull/3116/files and this is, sadly, the behavior expected by AWS as described here https://github.com/hashicorp/terraform-provider-aws/blob/v3.47.0/docs/contributing/retries-and-waiters.md#iam-error-retries.

for more information check the related PR: claranet/terraform-signalfx-integrations#35 (comment)

@atoulme
Copy link
Contributor

atoulme commented Oct 16, 2024

Closing this issue as unplanned. If this issue is still relevant, please reopen the issue.

@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants