Fixed broken package configuration #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pion failed finding the file when being used as a submodule.
| @@ -141,7 +141,7 @@ install(TARGETS ${PROJECT_NAME} | |||
| ) | |||
|
|
|||
| include(CMakePackageConfigHelpers) | |||
| configure_file(${CMAKE_SOURCE_DIR}/cmake/modules/lib${PROJECT_NAME}-config.cmake.in | |||
| configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/modules/lib${PROJECT_NAME}-config.cmake.in | |||
| ${CMAKE_CURRENT_BINARY_DIR}/lib${PROJECT_NAME}-config.cmake | |||
There was a problem hiding this comment.
Will changing ${CMAKE_SOURCE_DIR} to ${PION_SRC_ROOT} can help?
Just to skip ``../`
|
Also i've noticed that for some reason, the pion artifacts are build relative to pion's directory suprizes me, since |
|
@Anticom Well it was a long time ago :) |
|
👍 LGTM |
|
I'll have a look at the CMake build files. Maybe I can contribute the rewrite you're talking about @snikulov |
|
Any updates on whether and if so when the PR will be merged eventually? 😉 |
firedaemon-cto
pushed a commit
to FireDaemon/pion
that referenced
this pull request
Aug 27, 2020
firedaemon-cto
pushed a commit
to FireDaemon/pion
that referenced
this pull request
Aug 27, 2020
* Synchronize each miscrosec test to the next second (splunk#109) * Synchronize each miscrosec test to the next second The aim is to avoid false positives in test_microsec when the seconds, minutes or hours change during time read between the second_clock and the microsec_clock. * Improved readability of the microcec_time_clock test * Improve performance of adding and subtracting time durations from a ptime. (splunk#99) Modifying ptime objects by adding and subtracting time durations was inefficient because it extracted the date and time of day and then re-constructed a ptime using the date and modified time of day. This can be avoided by using the existing time_system utilities which perform the operation by adjusting the number of ticks. Performance is improved by a factor of 48 on my system. * Update CI Scripts * Add time_duration helper functions: (splunk#113) 1. is_positive() - Return boolean value to indicate whether or not time duration is positive. 2. is_zero() - Return boolean value to indicate whether or not time duration is zero. 3. abs() - Return a time_duration which is the absolute value of time duration. Added documentation for these helper functions and improved existing documentation to indicate constness, return values or static functions. * Cease dependence on MPL (splunk#115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pion failed finding the file when being used as a submodule.
Steps to reproduce (tested on linux):
foofoo/CMakeLists.txtthat hasadd_subdirectory("pion")in itfoo(so you getfoo/pion/...)foo/Releasefoo/Releaseand run cmake ..This change makes the file being configured relative to the current directory
src/CMakeLists.txtis placed in. MaybePION_SRC_ROOTcould have been used, however this is working aswell.