Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wget/Curl Download and Bash Execution: Changing logic for search terms, to make searches comply with title and intention #2997

Merged

Conversation

DipsyTipsy
Copy link
Contributor

@DipsyTipsy DipsyTipsy commented Apr 10, 2024

Details

The logic in the queries here has an OR between the matching on quiet/stdout and the match for pipe and "bash".
This causes the query to hit when wget/curl is either silenced or piped to bash.
From the title i would maybe assume that an AND between the quiet/stdout check and pipe+bash check would be the correct queries?

Searches modified:

  • Wget Download and Bash Execution
  • Curl Download and Bash Execution

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.

@DipsyTipsy DipsyTipsy marked this pull request as ready for review April 10, 2024 11:43
@DipsyTipsy DipsyTipsy changed the title Changing logic for search terms, to make searches comply with title and intention Wget/Curl Download and Bash Execution: Changing logic for search terms, to make searches comply with title and intention Apr 10, 2024
@patel-bhavin patel-bhavin requested review from MHaggis and removed request for patel-bhavin and P4T12ICK April 11, 2024 17:38
@patel-bhavin patel-bhavin requested a review from ljstella as a code owner August 22, 2024 15:31
@patel-bhavin patel-bhavin removed the request for review from ljstella August 22, 2024 16:04
@MHaggis
Copy link
Contributor

MHaggis commented Aug 27, 2024

Hey @DipsyTipsy , we are working to fix this up. I agree with your fixes. We're in the midst of ensuring we can generate new data that we can test against. We appreciate the feedback and apologize for the long delay in getting this resolved.

@MHaggis
Copy link
Contributor

MHaggis commented Nov 7, 2024

Hey @DipsyTipsy , we got the updates updated. Apologies for the delay! This will go out next release along with a reference to you for your awesome help! Really appreciate the feedback and your patience!

@patel-bhavin
Copy link
Contributor

Hello @DipsyTipsy - sorry this took a bit for us to test, there are currently some TA limitations with the test data set but after testing this with @MHaggis , its evident that the detection needs to be fixed. We have added a note at the bottom of the yaml mentioning this limitation. Thank you for updating this detection !!

@patel-bhavin patel-bhavin merged commit 3b2cad7 into splunk:develop Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants