Improved comment for the upgrade condition

splunk · Jul 20, 2023 · 26efb68 · akondur · Jul 20, 2023 · 26efb68
1 parent be99408
commit 26efb68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/splunk/enterprise/clustermanager.go b/pkg/splunk/enterprise/clustermanager.go
@@ -503,7 +503,8 @@ func isClusterManagerReadyForUpgrade(ctx context.Context, c splcommon.Controller
 		return false, err
 	}
 
-	// check if an image upgrade is happening and whether the ClusterManager is ready for the upgrade
+	// check if an image upgrade is happening and whether LM has finished updating yet, return false to stop
+	// further reconcile operations on CM until LM is ready
 	if (cr.Spec.Image != cmImage) && (licenseManager.Status.Phase != enterpriseApi.PhaseReady || lmImage != cr.Spec.Image) {
 		return false, nil
 	}

diff --git a/pkg/splunk/enterprise/monitoringconsole.go b/pkg/splunk/enterprise/monitoringconsole.go
@@ -413,7 +413,8 @@ func isMonitoringConsoleReadyForUpgrade(ctx context.Context, c splcommon.Control
 		return false, err
 	}
 
-	// check if an image upgrade is happening and whether the ClusterManager is ready for the upgrade
+	// check if an image upgrade is happening and whether CM has finished updating yet, return false to stop
+	// further reconcile operations on MC until CM is ready
 	if (cr.Spec.Image != mcImage) && (clusterManager.Status.Phase != enterpriseApi.PhaseReady || cmImage != cr.Spec.Image) {
 		return false, nil
 	}