fixed semgrep findings

Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>

pkg/splunk/enterprise/cp.go

@@ -19,6 +19,7 @@ import (
 	"archive/tar"
 	"io"
 	"os"
+	"path/filepath"
 )
 
 var cpMakeTar = func(src localPath, dest remotePath, writer io.Writer) error {
@@ -85,7 +86,7 @@ func recursiveTar(srcDir, srcFile localPath, destDir, destFile remotePath, tw *t
 			if err := tw.WriteHeader(hdr); err != nil {
 				return err
 			}
-
+			fpath = filepath.Clean(fpath)
 			f, err := os.Open(fpath)
 			if err != nil {
 				return err

pkg/splunk/enterprise/util.go

@@ -427,7 +427,7 @@ func createAppDownloadDir(ctx context.Context, path string) error {
 	scopedLog := reqLogger.WithName("createAppDownloadDir").WithValues("path", path)
 	_, err := os.Stat(path)
 	if errors.Is(err, os.ErrNotExist) {
-		errDir := os.MkdirAll(path, 0755)
+		errDir := os.MkdirAll(path, 0700)
 		if errDir != nil {
 			scopedLog.Error(errDir, "Unable to create directory at path")
 			return errDir
@@ -447,7 +447,7 @@ func getAvailableDiskSpace(ctx context.Context) (uint64, error) {
 	if err != nil {
 		scopedLog.Error(err, "There is no default volume configured for the App framework, use the temporary location", "dir", TmpAppDownloadDir)
 		splcommon.AppDownloadVolume = TmpAppDownloadDir
-		err = os.MkdirAll(splcommon.AppDownloadVolume, 0755)
+		err = os.MkdirAll(splcommon.AppDownloadVolume, 0700)
 		if err != nil {
 			scopedLog.Error(err, "Unable to create the directory", "dir", splcommon.AppDownloadVolume)
 			return 0, err

tools/k8s_collectors/k8s-splunk-collector-helper.py

@@ -1,10 +1,12 @@
 from __future__ import print_function
 import os
+import shlex
 import sys, getopt
 import subprocess
 
 def executeShellCommand(command):
-   stream = subprocess.popen(command).wait()
+   cmdlist = shlex.split(command)
+   stream = subprocess.Popen(cmdlist).wait()
    output = stream.read()
    return output
 
@@ -21,7 +23,7 @@ def runAndCollectDiag(collectDir, podDiagsDir, pod):
             if len(dirs) >= 2 and len(dirs[3]) > 0:
                 diagFile = dirs[3]
 
-            #Copy the diag over            
+            #Copy the diag over
             executeShellCommand("kubectl cp %s:%s %s/%s/%s" % (pod, diagFileFullPath, collectDir, podDiagsDir, diagFile))
 
             #Delete the diag