Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Develop to main for Splunk Operator Release 2.3.0 #1199

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Promote Develop to main for Splunk Operator Release 2.3.0 #1199

merged 5 commits into from
Jul 25, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automated Pull Request To Merge Develop To Main For Release Version 2.3.0

gaurav-splunk and others added 2 commits June 29, 2023 12:49
@gaurav-splunk
Merge pull request #1185 from splunk/main
59a9aed 
merge from main to develop after release 2.3.0
@vivekr-splunk
host multiple splunk operator helm chart on github.io (#1190)
bac7dbd 
* host splunk operator versions in artifactory

* adding 2.3.0 image changes to chart

* removed artifact manifest file

Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>

* changed documentation

---------

Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>
@vivekr-splunk
fixed semgrep findings
785365a 
Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>
@vivekr-splunk
fixed kubectl command in Popen
b61b5e2 
Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>
@vivekr-splunk
ignore tools files in semgrep
e1062ba 
Signed-off-by: vivekr-splunk <94569031+vivekr-splunk@users.noreply.github.com>
jfreydank-splunk
jfreydank-splunk approved these changes Jul 25, 2023
View reviewed changes
Copy link

@jfreydank-splunk jfreydank-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks acceptable. Frist command is hardcoded, next command args cannot be chained by ";<>" because popen does not invoke shell.
Make sure to eave shell=False.

@gaurav-splunk gaurav-splunk merged commit c753096 into main Jul 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekr-splunk vivekr-splunk vivekr-splunk approved these changes

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@jfreydank-splunk jfreydank-splunk jfreydank-splunk approved these changes

@gaurav-splunk gaurav-splunk gaurav-splunk approved these changes

@jryb jryb Awaiting requested review from jryb

@kumarajeet kumarajeet Awaiting requested review from kumarajeet

@pdhanoya-splunk pdhanoya-splunk Awaiting requested review from pdhanoya-splunk

@sgontla sgontla Awaiting requested review from sgontla

@smohan-splunk smohan-splunk Awaiting requested review from smohan-splunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-splunk @vivekr-splunk @jfreydank-splunk