chore: update docs #48
Conversation
|
@linnnsss please help check |
| @@ -9,6 +9,7 @@ pub enum Error { | |||
| Encoding, | |||
|
|
|||
| // common | |||
| InvalidClusterData, | |||
There was a problem hiding this comment.
Will error-num change affect spore-sdk?
@ShookLyngs
There was a problem hiding this comment.
Yes it will, because the contracts need to be redeployed.
And then the sdk need to upadte the referenced contracts' info.
There was a problem hiding this comment.
slightly changes will influent code hash of contracts, it's a little inconvenient for a minor update, what do you think of we let SDK fetch contract info from a version service?
for example, after I deployed contracts, a version file will be generated automatically in the root dir, and you can just use a url to read from it?
There was a problem hiding this comment.
Personally, I believe that hardcoded code hashes can assist in identifying errors returned by RPC.
Maybe this can be seen as a "left hand or right hand" problem, you cannot have both.
There was a problem hiding this comment.
make sense, it leads to that we have to be cautious with our version upgrade, it's better to combine some changes to a upgrade package
ashuralyk
force-pushed
the
chore/deployment-publish
branch
from
16d1f93 to
430076a
Compare
|
@ShookLyngs please use contracts deployment information in this PR and update SDK again, current on-chain deployment information isn't the latest one |
Description
arrange documentations, and add some debug printings in Spore contract