Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix compatibility within v1 and v2 #50

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Conversation

ashuralyk
Copy link
Contributor

Description

to solve the compatibility problem about ClusterData molecule structure

Tasks list

@ashuralyk
Copy link
Contributor Author

@ashuralyk ashuralyk self-assigned this Jan 19, 2024
@ashuralyk ashuralyk added bug Something isn't working compatibility compatible issues between different versions labels Jan 19, 2024
tests/src/tests/spore.rs Show resolved Hide resolved
tests/src/tests/spore.rs Show resolved Hide resolved
lib/utils/src/lib.rs Show resolved Hide resolved
Copy link
Collaborator

@ShookLyngs ShookLyngs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some full tests on the testnet, as well as some individual tests (create Spore with Cluster V1 and create ClusterProxy with Cluster V1). In my tests, I didn't encounter the -1 error again.

ashuralyk and others added 2 commits January 20, 2024 13:19
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
@ashuralyk ashuralyk merged commit b97831a into master Jan 20, 2024
2 checks passed
@ashuralyk ashuralyk deleted the bug/v1-v2-compatibility branch January 20, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility compatible issues between different versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-1 When attempting to create Spore with Cluster V1
3 participants