Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove useless deployed spore contract #59

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

ashuralyk
Copy link
Contributor

@ashuralyk ashuralyk commented Feb 27, 2024

Description

split toml directory into mainnet and testnet two sub-directories, and then, consume an useless deployed Spore contract cell and withdraw its locked capacity.

besides, writing a toolchain to automatically manage contract deployment is not easy, so I've suggested we just regulate a principle of deployment as the method.

cc @Flouse @ShookLyngs

Related Issues

@ashuralyk ashuralyk self-assigned this Feb 27, 2024
@ashuralyk ashuralyk requested review from quake and xxuejie March 5, 2024 03:34
@ashuralyk ashuralyk requested review from joii2020 and removed request for roughpandaz March 13, 2024 01:53
@joii2020
Copy link
Collaborator

I found that before, the tests in ./Cargo.toml were moved from exclude to members. But this will lead to: every time the dependencies of tests are modified, it may affect the compilation of on-chain script.

@ashuralyk ashuralyk force-pushed the chore/deployment-adjust branch from 9e9dc5e to d258603 Compare March 14, 2024 07:27
@ashuralyk
Copy link
Contributor Author

I found that before, the tests in ./Cargo.toml were moved from exclude to members. But this will lead to: every time the dependencies of tests are modified, it may affect the compilation of on-chain script.

rebased and fixed

@ashuralyk ashuralyk merged commit 81315ca into master Mar 14, 2024
12 checks passed
@ashuralyk ashuralyk deleted the chore/deployment-adjust branch March 14, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants