feat: change payment from u8 to u64 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashuralyk
requested review from
Flouse,
roughpandaz,
ShookLyngs,
quake and
xxuejie
ashuralyk
force-pushed
the
feat/change-payment-method
branch
from
2d781f8 to
c83b005
Compare
joii2020
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we've discussed it's non-sense that using the same payment check method with Omni and ACP, because it's a bit inconvenient to users.
so the result is to change payment flag from
u8tou64, which directly represents the CKB capacity, not the power of 10.BTW,
spore-sdkshould adapt to this change later.cc @Flouse @ShookLyngs
Related Issues
min_paymentfrom Uint8 to Uint64 #43