Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for URL and return error if invalid #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check for URL and return error if invalid #58

wants to merge 1 commit into from

Conversation

JeffHCross
Copy link

@JeffHCross JeffHCross commented Feb 17, 2023 •
edited
Loading

Resolves #13
Checks for invalid URLs in sportsdataverse.cfb.load_cfb_schedule and sportsdataverse.cfb.load_cfb_pbp, raising SeasonNotFoundError if the URL is not valid

@vercel
Copy link

vercel bot commented Feb 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sportsdataverse-py ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 17, 2023 at 6:58PM (UTC)

@JeffHCross
Copy link
Author

JeffHCross commented Feb 17, 2023 •
edited
Loading

I didn't notice how sportsdataverse.cfb.load_cfb_team_info handles Exceptions until after I had written valid_url, so hopefully you don't mind the different approach.

@JeffHCross JeffHCross changed the title Resolves #13 -- check for URL and return error if invalid Check for URL and return error if invalid Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saiemgilani saiemgilani Awaiting requested review from saiemgilani

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 error in games
1 participant
@JeffHCross