Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 season data #36

Open
hypebright opened this issue May 12, 2024 · 1 comment
Open

2024 season data #36

hypebright opened this issue May 12, 2024 · 1 comment

Comments

@hypebright
Copy link

Hi @saiemgilani,

Currently some of the functions break because there's no 2024 data in sportsdataverse-data. For example:

> wnba_pbp <- wehoop::load_wnba_pbp()
Warning in readRDS(con) :
  cannot open URL 'https://github.com/sportsdataverse/sportsdataverse-data/releases/download/espn_wnba_pbp/play_by_play_2024.rds': HTTP status was '404 Not Found'
Warning: Failed to readRDS from <https://github.com/sportsdataverse/sportsdataverse-data/releases/download/espn_wnba_pbp/play_by_play_2024.rds>

This is because most_recent_wnba_season returns 2024 as it's now May. Do you have plans to add the 2024 data in the short term?

Thanks!
@saiemgilani
Copy link
Collaborator

Oof, an old mistake coming back to bite me

Will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saiemgilani @hypebright