Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the update command #7

Closed
wants to merge 4 commits into from
Closed

Changed the update command #7

wants to merge 4 commits into from

Conversation

Jnv821
Copy link
Contributor

@Jnv821 Jnv821 commented Jun 1, 2022

Changed the update command to work properly. The most important change on the order of evaluation ( if force first rather than match / case statement. Locations have been changed in order to fit the discord markdown.

Changed the update command to work correctly
Copy link
Member

@Silverarmor Silverarmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the changes below - Have you run your own tests to ensure this new solution works?

type=interactions.OptionType.BOOLEAN,
name="force",
description="Use --force-resintall flag?",
require="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require="false"
required=False

name="force",
description="Use --force-reinstall flag?",
required=False,
options=[ interactions.Option(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please comply with flake8/pep8/linting, place the interactions.Option( on the next line


await ctx.send(message)

response_message = (base_message + "https://codeload.github.com/spotDL/spotdl-v4/zip/master`")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in the case of v4, won't this print base_message + v4 link

To update spotDL, run `pip install -U spotdl https://codeload.github.com/spotDL/spotdl-v4/zip/master`

@Silverarmor Silverarmor linked an issue Jun 1, 2022 that may be closed by this pull request
Restored commands.py to original file with just the change of the update line
Delete the file with changes that were not needed to restore to original code which is clearer and doesn't need a complex workaround
changed the directory of commands.py to /extensions/
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update command not working
2 participants