From 4e999983e42a4a752cdd0b2fb5952a94b8344273 Mon Sep 17 00:00:00 2001
From: Jeremy Landis <jeremylandis@hotmail.com>
Date: Mon, 25 Dec 2023 06:38:38 -0500
Subject: [PATCH] [cleanup] Cleanup location of properties or remove unused

---
 .../org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy   | 2 --
 .../codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy    | 5 ++---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy
index 639f2c175..0a79fd419 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy
@@ -57,8 +57,6 @@ trait SpotBugsPluginsTrait {
     String getSpotbugsPlugins() {
         ResourceHelper resourceHelper = new ResourceHelper(log, spotbugsXmlOutputDirectory, resourceManager)
 
-        URL[] pluginURL
-
         String urlPlugins = ""
 
         if (pluginList) {
diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
index 212feea37..6a0262a01 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
@@ -438,15 +438,13 @@ class SpotbugsReportGenerator implements SpotBugsInfo {
      *
      */
     protected String assembleJxrHyperlink(GPathResult line) {
-        String hyperlink
-        String prefix
-
         log.debug("Inside assembleJxrHyperlink")
         log.debug("line is " + line.text())
         log.debug("outputDirectory is " + outputDirectory.getAbsolutePath())
         log.debug("xrefLocation is " + xrefLocation.getAbsolutePath())
         log.debug("xrefTestLocation is " + xrefTestLocation.getAbsolutePath())
 
+        String prefix
         compileSourceRoots.each { compileSourceRoot ->
             if (!new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists()) {
                 return
@@ -468,6 +466,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo {
         String path = prefix + line.@classname.text().replaceAll("[.]", "/").replaceAll("[\$].*", "")
         String lineNumber = valueForLine(line)
 
+        String hyperlink
         if (lineNumber != bundle.getString(NOLINE_KEY)) {
             hyperlink = "<a href=\"" + path + ".html#L" + line.@start.text() + "\">" + lineNumber + "</a>"
         } else {