Merge pull request #731 from hazendaz/master

[site] Fix missing parts of site after upgrade

README.md

@@ -69,7 +69,7 @@ mvn com.github.spotbugs:spotbugs-maven-plugin:4.8.2.0:gui
 ```
 mvn -DtestSrc=remote -Prun-its clean install -D"invoker.parallelThreads=4"
 
-Then replace current src/site/resources entirely with any working example 'site' folder from there (Currently uses basic-1).
+Then replace current src/site/resources entirely with any working example 'site' folder from there (Currently uses basic-1).  Also top files top level of the basic site folder 'spotbugs.xml' and 'spotbugsXml.xml'.
 ```
 
 ## Contributing ##

src/site/resources/examples/spotbugs.xml

@@ -0,0 +1,2 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<BugCollection version='4.8.3' threshold='medium' effort='default'><file classname='AbstractMissingHashCode$Concrete'><BugInstance type='EQ_UNUSUAL' priority='Normal' category='STYLE' message='AbstractMissingHashCode$Concrete.equals(Object) is unusual' lineNumber='33'/><BugInstance type='UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD' priority='Normal' category='STYLE' message='Unused public or protected field: AbstractMissingHashCode$Concrete.z' lineNumber='-1'/></file><file classname='AbstractMissingHashCode$ConcreteMissingEquals'><BugInstance type='EQ_DOESNT_OVERRIDE_EQUALS' priority='Normal' category='STYLE' message='AbstractMissingHashCode$ConcreteMissingEquals doesn&apos;t override AbstractMissingHashCode$Concrete.equals(Object)' lineNumber='1'/><BugInstance type='UUF_UNUSED_FIELD' priority='Normal' category='PERFORMANCE' message='Unused field: AbstractMissingHashCode$ConcreteMissingEquals.z' lineNumber='-1'/></file><file classname='AbstractMissingHashCode$StillMissingHashCode'><BugInstance type='HE_INHERITS_EQUALS_USE_HASHCODE' priority='Normal' category='BAD_PRACTICE' message='AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode()' lineNumber='16'/><BugInstance type='UUF_UNUSED_FIELD' priority='Normal' category='PERFORMANCE' message='Unused field: AbstractMissingHashCode$StillMissingHashCode.y' lineNumber='-1'/></file><file classname='AccidentalNonConstructorInInnerClass$DoNotReport'><BugInstance type='SIC_INNER_SHOULD_BE_STATIC' priority='Normal' category='PERFORMANCE' message='Should AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class?' lineNumber='21'/></file><file classname='AccidentalNonConstructorInInnerClass$Report'><BugInstance type='SIC_INNER_SHOULD_BE_STATIC' priority='Normal' category='PERFORMANCE' message='Should AccidentalNonConstructorInInnerClass$Report be a _static_ inner class?' lineNumber='3'/></file><file classname='AppendingToAnObjectOutputStream'><BugInstance type='IO_APPENDING_TO_OBJECT_OUTPUT_STREAM' priority='High' category='CORRECTNESS' message='Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)' lineNumber='14'/><BugInstance type='IO_APPENDING_TO_OBJECT_OUTPUT_STREAM' priority='High' category='CORRECTNESS' message='Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)' lineNumber='21'/><BugInstance type='IO_APPENDING_TO_OBJECT_OUTPUT_STREAM' priority='High' category='CORRECTNESS' message='Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)' lineNumber='28'/><BugInstance type='IO_APPENDING_TO_OBJECT_OUTPUT_STREAM' priority='High' category='CORRECTNESS' message='Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)' lineNumber='35'/></file><file classname='ArrayToString'><BugInstance type='DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY' priority='Normal' category='CORRECTNESS' message='Invocation of toString on an unnamed array in ArrayToString.print2()' lineNumber='28'/><BugInstance type='DMI_INVOKING_TOSTRING_ON_ARRAY' priority='Normal' category='CORRECTNESS' message='Invocation of toString on ? in ArrayToString.print0(String[])' lineNumber='17'/><BugInstance type='DMI_INVOKING_TOSTRING_ON_ARRAY' priority='Normal' category='CORRECTNESS' message='Invocation of toString on ? in ArrayToString.print1()' lineNumber='23'/><BugInstance type='DMI_INVOKING_TOSTRING_ON_ARRAY' priority='Normal' category='CORRECTNESS' message='Invocation of toString on gargs in ArrayToString.print3()' lineNumber='33'/></file><file classname='AssumeUnsignedBytes'><BugInstance type='INT_BAD_COMPARISON_WITH_SIGNED_BYTE' priority='High' category='CORRECTNESS' message='Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])' lineNumber='8'/></file><file classname='UseOfNonHashableClassInHashDataStructure'><BugInstance type='EQ_UNUSUAL' priority='Normal' category='STYLE' message='UseOfNonHashableClassInHashDataStructure.equals(Object) is unusual' lineNumber='16'/><BugInstance type='HE_EQUALS_USE_HASHCODE' priority='High' category='BAD_PRACTICE' message='UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()' lineNumber='16'/><BugInstance type='HE_USE_OF_UNHASHABLE_CLASS' priority='High' category='CORRECTNESS' message='UseOfNonHashableClassInHashDataStructure doesn&apos;t define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)' lineNumber='24'/><BugInstance type='NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT' priority='Normal' category='BAD_PRACTICE' message='UseOfNonHashableClassInHashDataStructure.equals(Object) does not check for null argument' lineNumber='16'/></file><file classname='UseOfNonHashableClassInHashDataStructure$UMap'><BugInstance type='HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS' priority='High' category='CORRECTNESS' message='UseOfNonHashableClassInHashDataStructure doesn&apos;t define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap' lineNumber='5'/></file><file classname='UselessAssignments'><BugInstance type='DLS_DEAD_LOCAL_STORE' priority='Normal' category='STYLE' message='Dead store to $L2 in new UselessAssignments(int, int)' lineNumber='17'/><BugInstance type='DLS_OVERWRITTEN_INCREMENT' priority='High' category='CORRECTNESS' message='Overwritten increment in UselessAssignments.oops()' lineNumber='30'/><BugInstance type='SA_FIELD_DOUBLE_ASSIGNMENT' priority='Normal' category='STYLE' message='Double assignment of field g1 in new UselessAssignments(int, int)' lineNumber='18'/><BugInstance type='SA_FIELD_DOUBLE_ASSIGNMENT' priority='Normal' category='STYLE' message='Double assignment of field foo in UselessAssignments.oops()' lineNumber='31'/><BugInstance type='SA_FIELD_DOUBLE_ASSIGNMENT' priority='Normal' category='STYLE' message='Double assignment of field foo in UselessAssignments.report(UselessAssignments, UselessAssignments)' lineNumber='37'/><BugInstance type='SA_FIELD_DOUBLE_ASSIGNMENT' priority='Normal' category='STYLE' message='Double assignment of field bar in UselessAssignments.setFoo(UselessAssignments, UselessAssignments)' lineNumber='24'/><BugInstance type='SA_FIELD_SELF_ASSIGNMENT' priority='High' category='CORRECTNESS' message='Self assignment of field foo in new UselessAssignments(int, int)' lineNumber='16'/><BugInstance type='SA_FIELD_SELF_ASSIGNMENT' priority='High' category='CORRECTNESS' message='Self assignment of field foo in UselessAssignments.oops()' lineNumber='31'/><BugInstance type='SA_LOCAL_DOUBLE_ASSIGNMENT' priority='Normal' category='STYLE' message='Double assignment of $L3 in new UselessAssignments(int, int)' lineNumber='19'/><BugInstance type='SA_LOCAL_SELF_ASSIGNMENT' priority='Normal' category='STYLE' message='Self assignment of $L2 in new UselessAssignments(int, int)' lineNumber='17'/><BugInstance type='URF_UNREAD_FIELD' priority='Normal' category='PERFORMANCE' message='Unread field: UselessAssignments.bar' lineNumber='24'/><BugInstance type='URF_UNREAD_FIELD' priority='Normal' category='PERFORMANCE' message='Unread field: UselessAssignments.g1' lineNumber='18'/><BugInstance type='UR_UNINIT_READ' priority='High' category='CORRECTNESS' message='Uninitialized read of foo in new UselessAssignments(int, int)' lineNumber='16'/><BugInstance type='UUF_UNUSED_FIELD' priority='Normal' category='PERFORMANCE' message='Unused field: UselessAssignments.g2' lineNumber='-1'/></file><file classname='UselessControlFlow'><BugInstance type='UCF_USELESS_CONTROL_FLOW' priority='Normal' category='STYLE' message='Useless control flow in UselessControlFlow.report0(Object, Object)' lineNumber='14'/><BugInstance type='UCF_USELESS_CONTROL_FLOW' priority='Normal' category='STYLE' message='Useless control flow in UselessControlFlow.report1(Object, Object)' lineNumber='21'/><BugInstance type='UC_USELESS_VOID_METHOD' priority='Normal' category='STYLE' message='Method UselessControlFlow.report4(Object[], Object) seems to be useless' lineNumber='48'/></file><file classname='UselessCurrentThread'><BugInstance type='DLS_DEAD_LOCAL_STORE' priority='Normal' category='STYLE' message='Dead store to $L1 in UselessCurrentThread.test4()' lineNumber='42'/><BugInstance type='EI_EXPOSE_REP2' priority='Normal' category='MALICIOUS_CODE' message='new UselessCurrentThread(Thread) may expose internal representation by storing an externally mutable object into unknownThread' lineNumber='12'/><BugInstance type='STI_INTERRUPTED_ON_UNKNOWNTHREAD' priority='Normal' category='CORRECTNESS' message='UselessCurrentThread.test4() invokes static Thread.interrupted() method on thread instance' lineNumber='43'/><BugInstance type='STI_INTERRUPTED_ON_UNKNOWNTHREAD' priority='Normal' category='CORRECTNESS' message='UselessCurrentThread.test5() invokes static Thread.interrupted() method on thread instance' lineNumber='52'/></file><file classname='UselessFinalize'><BugInstance type='FI_USELESS' priority='Normal' category='BAD_PRACTICE' message='UselessFinalize.finalize() does nothing except call super.finalize(); delete it' lineNumber='4'/></file><file classname='UserMistakes'><BugInstance type='DLS_DEAD_LOCAL_STORE' priority='Normal' category='STYLE' message='Dead store to $L3 in UserMistakes.main(String[])' lineNumber='28'/><BugInstance type='DMI_HARDCODED_ABSOLUTE_FILENAME' priority='Normal' category='STYLE' message='Hard coded reference to an absolute pathname in UserMistakes.main(String[])' lineNumber='26'/><BugInstance type='DM_DEFAULT_ENCODING' priority='High' category='I18N' message='Found reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)' lineNumber='26'/><BugInstance type='RE_POSSIBLE_UNINTENDED_PATTERN' priority='Normal' category='CORRECTNESS' message='"." or "|" used for regular expression in UserMistakes.main(String[])' lineNumber='14'/><BugInstance type='RV_DONT_JUST_NULL_CHECK_READLINE' priority='Normal' category='STYLE' message='UserMistakes.main(String[]) discards result of readLine after checking if it is non-null' lineNumber='27'/></file><file classname='org.codehaus.mojo.spotbugsmavenplugin.it.App'><BugInstance type='CN_IDIOM_NO_SUPER_CALL' priority='Normal' category='BAD_PRACTICE' message='org.codehaus.mojo.spotbugsmavenplugin.it.App.clone() does not call super.clone()' lineNumber='29'/><BugInstance type='NP_CLONE_COULD_RETURN_NULL' priority='Normal' category='BAD_PRACTICE' message='org.codehaus.mojo.spotbugsmavenplugin.it.App.clone() may return null' lineNumber='29'/></file><Error></Error><Project><SrcDir>C:\Users\Jeremy\GitHub\spotbugs-maven-plugin\target\it-src-spotbugs\spotbugsTestCases\src\java</SrcDir><SrcDir>C:\Users\Jeremy\GitHub\spotbugs-maven-plugin\target\it\basic-1\target\generated-sources\annotations</SrcDir><SrcDir>C:\Users\Jeremy\GitHub\spotbugs-maven-plugin\src\it-src\test\java</SrcDir><SrcDir>C:\Users\Jeremy\GitHub\spotbugs-maven-plugin\target\it\basic-1\target\generated-test-sources\test-annotations</SrcDir></Project></BugCollection>