-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative model serializations for inference #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drubinstein
force-pushed
the
drubinstein/pt
branch
30 times, most recently
from
October 3, 2023 01:14
d0c91dd
to
8601ef9
Compare
drubinstein
force-pushed
the
drubinstein/pt
branch
from
February 29, 2024 21:12
bfb4386
to
76a759c
Compare
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
reviewed
Mar 6, 2024
bgenchel
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most things look good from what I can understand though i'd like to understand a bit more before approving; there is one comment I left for a small change in the init.py text output.
bgenchel
previously approved these changes
Mar 12, 2024
bgenchel
reviewed
Mar 12, 2024
bgenchel
reviewed
Mar 12, 2024
bgenchel
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pretty large refactor. One issue we've seen is that not all users are TensorFlow users and TensorFlow is a pretty heavy dependency. To alleviate that, this PR adds in TFLite, CoreML and ONNX serialized versions of the models. PyTorch is not included for now, but we plan to include it in the future.
Instead of TF being a default dependency, depending on the platform, a different model serialization format will be used by defualt. Instead TF is now an extra that can be installed via
basic-pitch[tf]
.tflite-runtime
package (which only supports linux)coremltools
package (which only supports mac)onnxruntime
package (which supports all platforms)However, if TF is detected on the system, it will be used instead. Ideally, this change will speed up initialization and install times at the cost of a slightly larger binary due to the inclusion of all the new serialized models.
In addition, related to a red herring when failing to install scipy in Python 3.11, I decided to also move from
setup.cfg
topyproject.toml
format in this PR. I can move that to another PR if desired.I believe we can call this a minor bump since there are no breaking changes, but we can also call this a major bump due to the possible results changes for users.