Add Maestro #130
Merged
Add Maestro #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d data and tests + uploaded download.py for maestro, added test data for maestro, updated Manifest for wav and midi files in test
drubinstein
reviewed
Jul 25, 2024
… repo. Also removed metadata csv file as it wasn't being used in the code.
drubinstein
reviewed
Jul 30, 2024
… test files referenced, modified test_maestro_create_input_data to work with this.
drubinstein
reviewed
Jul 31, 2024
…ove debugging prints.
drubinstein
reviewed
Jul 31, 2024
drubinstein
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tolerance for ikala, test names for ikala and guitarset, added data and tests + uploaded download.py for maestro, added test data for maestro, updated Manifest for wav and midi files in test.
Unfortunately I had to roll a bunch of commits into one here because I added a too large file to one of the commits and soft reset to right before it in order to push.
In one of the tests I create and then delete a test file. Maybe I did this in a non-canonical or nonsafe way - please check.