Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Provider events #22

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Provider events #22

merged 7 commits into from
Aug 2, 2023

Conversation

Calibretto
Copy link
Contributor

An implementation of the provider events paradigm.

alina-v1
alina-v1 previously approved these changes Jul 31, 2023
Copy link
Contributor

@alina-v1 alina-v1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good implementation-wise. It fulfils required requirements of event spec. The only difference between spec and implementation is vocabulary of event details/provider event details vs user info, which I believe we just need to elaborate in our readme.

fabriziodemaria
fabriziodemaria previously approved these changes Aug 1, 2023
Copy link
Member

@fabriziodemaria fabriziodemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller comments, looks good!

Sources/OpenFeature/OpenFeatureAPI.swift Outdated Show resolved Hide resolved
@Calibretto Calibretto merged commit 42832f4 into main Aug 2, 2023
2 checks passed
@Calibretto Calibretto deleted the provider-events branch August 2, 2023 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants