Fix crash when removing namespaces from attributes in xml_import:parse

spraakbanken · May 20, 2024 · 9e3598b · 9e3598b · ljo · May 22, 2024
1 parent a039655
commit 9e3598b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,7 @@
 - Fixed Stanza which was broken for English.
 - SweNER no longer hangs on (extremely) long tokens.
 - Fixed config validation for `korp.context` and `korp.within`.
+- Fixed crash when removing namespaces from attributes in `xml_import:parse`.
 
 ## [5.2.0] - 2023-12-07
 

diff --git a/sparv/modules/xml_import/xml_import.py b/sparv/modules/xml_import/xml_import.py
@@ -342,7 +342,7 @@ def remove_namespaces(element: etree.Element):
             uri, _ = get_namespace(element.tag)
             if uri:
                 element.tag = element.tag[len("{" + uri + "}"):]
-            for k in element.attrib.keys():
+            for k in element.attrib.copy():
                 uri, _ = get_namespace(k)
                 if uri:
                     element.set(k[len("{" + uri + "}"):], element.attrib[k])