Added api exposure for logging in with an oauth access token. #237

Oldharlem · 2019-08-08T20:52:46Z

This PR adds the option to use a valid access token to authenticate with the application.
The omniauth strategies are used for the authentication but obtaining a token part is skipped. Instead, the token is directly fed to the strategy and the user info is retrieved via the strategy.

This feature would allow any API consumer with a valid token to register or login using this token.

Could not test since they seem broken on 3-1-stable. Is anybody else experiencing problems running the tests?

getting an undefined method 'load_defaults' for #<Rails::Application::Configuration:0x00007f8673c52e60> error

houndci-bot · 2019-08-08T20:55:51Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+  end
+end
+
+Spree::Api::V1::UsersController.prepend(Spree::Api::V1::UsersControllerDecorator)


Metrics/LineLength: Line is too long. [81/80]
Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2019-08-08T20:55:52Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+              :user_id => "#{user.id}"
+          }}
+        end
+


Layout/EmptyLinesAroundModuleBody: Extra empty line detected at module body end.

houndci-bot · 2019-08-08T20:55:52Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+              :user => "#{user.login}",
+              :api_key => "#{user.spree_api_key}",
+              :user_id => "#{user.id}"
+          }}


Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2019-08-08T20:55:52Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+          render :json => {:result => {
+              :user => "#{user.login}",
+              :api_key => "#{user.spree_api_key}",
+              :user_id => "#{user.id}"


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2019-08-08T20:55:52Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+        def render_user_login(user)
+          render :json => {:result => {
+              :user => "#{user.login}",
+              :api_key => "#{user.spree_api_key}",


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2019-08-08T20:55:53Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+          else
+            user = Spree::User.find_by_email(params[:email]) || Spree::User.new
+            user.apply_omniauth(omniauth_hash)
+            if user.save!


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

houndci-bot · 2019-08-08T20:55:53Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+          omniauth_hash = authentication_method.get_omniauth_hash(params[:oauth_token])
+          authentication = Spree::UserAuthentication.find_by_provider_and_uid(params[:provider], omniauth_hash['uid'])
+
+          if authentication.present? and authentication.try(:user).present?


Style/AndOr: Use && instead of and.

houndci-bot · 2019-08-08T20:55:53Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+          authentication_method = Spree::AuthenticationMethod.find_by_provider(params[:provider])
+          render json: {exception: 'Unsupported provider'}, status: 422 and return unless authentication_method
+          omniauth_hash = authentication_method.get_omniauth_hash(params[:oauth_token])
+          authentication = Spree::UserAuthentication.find_by_provider_and_uid(params[:provider], omniauth_hash['uid'])


Metrics/LineLength: Line is too long. [118/80]

houndci-bot · 2019-08-08T20:55:53Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+        def social_login
+          authentication_method = Spree::AuthenticationMethod.find_by_provider(params[:provider])
+          render json: {exception: 'Unsupported provider'}, status: 422 and return unless authentication_method
+          omniauth_hash = authentication_method.get_omniauth_hash(params[:oauth_token])


Metrics/LineLength: Line is too long. [87/80]

houndci-bot · 2019-08-08T20:55:53Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+
+        def social_login
+          authentication_method = Spree::AuthenticationMethod.find_by_provider(params[:provider])
+          render json: {exception: 'Unsupported provider'}, status: 422 and return unless authentication_method


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Style/AndOr: Use && instead of and.
Metrics/LineLength: Line is too long. [111/80]

…ut use safe_constantize instead

…the api key in their SDK

houndci-bot · 2019-08-14T09:47:41Z

app/models/spree/user_decorator.rb

+  def oauth_providers
+    user_authentications.map do |user_authentication|
+      {
+          provider: user_authentication.provider,


Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

houndci-bot · 2019-08-14T09:47:41Z

app/models/spree/authentication_method.rb

+  def strategy(token)
+    app = lambda {|env| [200, {}, ["Hello World."]]}
+    options = [api_key, api_secret]
+    strategy_class.new(app, *options).tap {|s| s.access_token = access_token(token)}


Layout/SpaceInsideBlockBraces: Space between { and | missing.
Metrics/LineLength: Line is too long. [84/80]
Layout/SpaceInsideBlockBraces: Space missing inside }.

houndci-bot · 2019-08-14T09:47:41Z

app/models/spree/authentication_method.rb

+  end
+
+  def strategy(token)
+    app = lambda {|env| [200, {}, ["Hello World."]]}


Style/Lambda: Use the -> { ... } lambda literal syntax for single line lambdas.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Lint/UnusedBlockArgument: Unused block argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used. Also consider using a proc without arguments instead of a lambda if you want it to accept any arguments but don't care about them.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/SpaceInsideBlockBraces: Space missing inside }.

houndci-bot · 2019-08-14T09:47:42Z

app/models/spree/authentication_method.rb

+  end
+
+  def client
+    ::OAuth2::Client.new(api_key, api_secret, strategy_class.default_options.client_options.to_h).tap do |c|


Metrics/LineLength: Line is too long. [108/80]

houndci-bot · 2019-08-14T09:47:42Z

app/models/spree/authentication_method.rb

+  end
+
+  def provider_must_be_backed_by_omniauth_strategy
+    errors.add(:provider, 'must be backed by an omniauth strategy') unless strategy_class.safe_constantize


Metrics/LineLength: Line is too long. [106/80]

houndci-bot · 2019-08-14T09:47:43Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+      module UsersControllerDecorator
+
+        def social_login
+          authentication_method = Spree::AuthenticationMethod.find_by_provider(params[:provider])


Metrics/LineLength: Line is too long. [97/80]

houndci-bot · 2019-08-14T09:47:43Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+    module V1
+      module UsersControllerDecorator
+
+        def social_login


Metrics/AbcSize: Assignment Branch Condition size for social_login is too high. [32.95/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for social_login is too high. [11/6]
Metrics/MethodLength: Method has too many lines. [22/10]
Metrics/PerceivedComplexity: Perceived complexity for social_login is too high. [12/7]

houndci-bot · 2019-08-14T09:47:43Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+  module Api
+    module V1
+      module UsersControllerDecorator
+


Layout/EmptyLinesAroundModuleBody: Extra empty line detected at module body beginning.

houndci-bot · 2019-08-14T09:47:43Z

app/controllers/spree/api/v1/users_controller_decorator.rb

+module Spree
+  module Api
+    module V1
+      module UsersControllerDecorator


Style/Documentation: Missing top-level module documentation comment.

houndci-bot · 2019-08-14T09:47:43Z

app/controllers/spree/api/v1/users_controller_decorator.rb

@@ -0,0 +1,64 @@
+module Spree


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

Oldharlem · 2019-09-20T11:10:31Z

Is this repo still active?

Oldharlem added 3 commits August 8, 2019 14:43

token based api login added

a2d8813

set rake to < 11 since rake >= 11 breaks rspec 3.2

0c5ddd8

minor touchup

b47824f

houndci-bot reviewed Aug 8, 2019

View reviewed changes

Oldharlem added 3 commits August 14, 2019 11:46

Refactor strategy class method to not depend on existence exception b…

4f1cff8

…ut use safe_constantize instead

Add API key to oauth_providers api call to allow any frontend to use …

113e259

…the api key in their SDK

Generate api key for user after social registration

2770f94

houndci-bot reviewed Aug 14, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added api exposure for logging in with an oauth access token. #237

Added api exposure for logging in with an oauth access token. #237

Oldharlem commented Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 8, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

houndci-bot Aug 14, 2019

Oldharlem commented Sep 20, 2019

Added api exposure for logging in with an oauth access token. #237

Are you sure you want to change the base?

Added api exposure for logging in with an oauth access token. #237

Conversation

Oldharlem commented Aug 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Oldharlem commented Sep 20, 2019