feat: Update task launch builder

Hide Default version on app if a version has been selected
spring-cloud · May 15, 2024 · 2a6d25b · 2a6d25b
1 parent ba60f31
commit 2a6d25b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/ui/src/app/tasks-jobs/tasks/launch/builder/builder.component.html b/ui/src/app/tasks-jobs/tasks/launch/builder/builder.component.html
@@ -496,7 +496,9 @@
                     <div class="cell">
                       <clr-select-container style="margin-top: 0">
                         <select tabindex="{{ 300 }}" [formControlName]="app.name" clrSelect>
-                          <option value="">{{ getLabelAppVersion(builder.taskLaunchConfig, app) }}</option>
+                          <option *ngIf="showDefaultVersion(builder.taskLaunchConfig, app)" value="">
+                            {{ getLabelAppVersion(builder.taskLaunchConfig, app) }}
+                          </option>
                           <option *ngFor="let version of app.versions" [value]="version.version">
                             {{ version.version }}
                           </option>

diff --git a/ui/src/app/tasks-jobs/tasks/launch/builder/builder.component.ts b/ui/src/app/tasks-jobs/tasks/launch/builder/builder.component.ts
@@ -852,6 +852,16 @@ export class BuilderComponent implements OnInit, OnDestroy {
     return version !== '' && !app.versions.find(v => v.version === version);
   }
 
+  showDefaultVersion(config: any, app: any): boolean {
+    const version = config.deploymentProperties
+      .map((prop: string) => prop.split('=')[0])
+      .find((prop: string) => prop === `version.${app.name}`);
+    if (version) {
+      return false;
+    }
+    return true;
+  }
+
   /**
    * Return true if the builder is valid
    * @param builder