Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the initializr link to use the java_version variable #129

Conversation

DominiqueComte
Copy link
Contributor

The Spring Initializr link used a hardcoded 11 value for the Java version instead of using the variable defined a few lines before.

The Spring Initializr link used a hardcoded 11 value for the Java version instead of using the variable defined a few lines before.
@robertmcnees robertmcnees merged commit d1d76b8 into spring-guides:main Aug 2, 2024
1 check passed
@robertmcnees
Copy link
Contributor

Thanks, @DominiqueComte. Good catch. I like this solution. Usually when we spot an old Java (or Boot) version in this link in our guides our go to solution is to omit the &jvmVersion= parameter entirely and let start.spring.io select the Java version by default. This seems like a good solution as well.

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants